wilfred-s commented on code in PR #374:
URL: https://github.com/apache/yunikorn-site/pull/374#discussion_r1465855316


##########
docs/developer_guide/deployment.md:
##########
@@ -60,18 +60,15 @@ This kubernetes environment can be either local or remote.
 ```
 curl -o yunikorn-configs.yaml 
https://raw.githubusercontent.com/apache/yunikorn-k8shim/master/deployments/scheduler/yunikorn-configs.yaml
 ```
-- modify the content of yunikorn-configs.yaml file as needed, and create 
ConfigMap in kubernetes:
+- modify the content of yunikorn-configs.yaml file as needed, and apply 
yunikorn-configs.yaml file in kubernetes:
 ```
-kubectl create configmap yunikorn-configs --from-file=yunikorn-configs.yaml
-```
-- Or update ConfigMap in kubernetes:
-```
-kubectl create configmap yunikorn-configs --from-file=yunikorn-configs.yaml -o 
yaml --dry-run=client | kubectl apply -f -
+kubectl apply -f yunikorn-configs.yaml
 ```
 - check if the ConfigMap was created/updated correctly:
 ```
 kubectl describe configmaps yunikorn-configs
 ```
+- for more configuration detail, see [Service 
Configuration](https://yunikorn.apache.org/docs/user_guide/service_config).

Review Comment:
   we should be using a relative link like `../user_guide/service_config.md`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to