craigcondit commented on code in PR #409:
URL: https://github.com/apache/yunikorn-site/pull/409#discussion_r1527477881
##########
local-build.sh:
##########
@@ -73,23 +76,13 @@ function run_base() {
if ! docker run -it --name yunikorn-site-local -d \
-p 3000:3000 \
-v "$PWD":/yunikorn-site \
+ --mount type=volume,dst=/yunikorn-site/node_modules \
Review Comment:
> It isolated the host's and docker's node_modules/ .
>
> Could I confirm what is the previous weirdness in the old build? I wasn't
aware of it before.
>
>
>
> > Most of the weirdness in the old build was due to node_modules being
(incorrectly) shared between the host and the Docker environment.
We had all sorts of strange brokenness around algolia search having to be
reinstalled constantly. I suspect there was platform-specific code being added
and this caused issues when node_modules was shared between different
platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
