craigcondit commented on PR #409: URL: https://github.com/apache/yunikorn-site/pull/409#issuecomment-2002417307
> Most of the changes looks good, tested in local and docker. > > > > One more minor change required: > > - yarn.lock in .gitignore could be removed. (https://github.com/apache/yunikorn-site/blob/master/.gitignore#L9) As I replied to the top level comment, I'd rather leave this in to prevent committing the lock file accidentally by other users since we previously used yarn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
