pbacsko commented on code in PR #821:
URL: https://github.com/apache/yunikorn-core/pull/821#discussion_r1530331805
##########
pkg/scheduler/objects/preemption.go:
##########
@@ -692,77 +696,58 @@ func (qps *QueuePreemptionSnapshot) Duplicate(copy
map[string]*QueuePreemptionSn
return snapshot
}
-// IsAtOrAboveGuaranteedResource determines if this queue is exceeding
resource guarantees and therefore
-// may be eligible for further preemption
-func (qps *QueuePreemptionSnapshot) IsAtOrAboveGuaranteedResource() bool {
+func (qps *QueuePreemptionSnapshot) GetPreemptableResource()
*resources.Resource {
if qps == nil {
- return false
+ return nil
}
- guaranteed := qps.GetGuaranteedResource()
- maxResource := qps.GetMaxResource()
- absGuaranteed := resources.ComponentWiseMinPermissive(guaranteed,
maxResource)
- used := resources.Sub(qps.AllocatedResource, qps.PreemptingResource)
+ parentPreemptableResource := qps.Parent.GetPreemptableResource()
+ used := qps.AllocatedResource.Clone()
- // if we don't fit, we're clearly above
- if !absGuaranteed.FitIn(used) {
- return true
+ // No usage, so nothing to preempt
+ if used.IsEmpty() {
+ return nil
}
-
- usedOrMax := resources.ComponentWiseMax(guaranteed, used)
- return resources.Equals(usedOrMax, used)
-}
-
-// IsWithinGuaranteedResource determines if this queue is within its current
resource guarantees
-func (qps *QueuePreemptionSnapshot) IsWithinGuaranteedResource() bool {
- if qps == nil {
- return true
+ used.SubOnlyExisting(qps.PreemptingResource)
+
+ // Calculate preemptable resource. +ve means Over utilized, -ve means
Under utilized, 0 means correct utilization
+ guaranteed := qps.GuaranteedResource.Clone()
+ actualPreemptableResource := used.Clone()
+ actualPreemptableResource.SubOnlyExisting(guaranteed)
+ preemptableResource := actualPreemptableResource.Clone()
Review Comment:
Is copy necessary? You can delete keys during iteration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
