wilfred-s commented on code in PR #822:
URL: https://github.com/apache/yunikorn-core/pull/822#discussion_r1542301534
##########
pkg/scheduler/objects/preemption.go:
##########
@@ -749,6 +749,64 @@ func (qps *QueuePreemptionSnapshot)
GetRemainingGuaranteed() *resources.Resource
return resources.ComponentWiseMin(remaining, parentResult)
}
+func (qps *QueuePreemptionSnapshot) GetPreemptableResource()
*resources.Resource {
+ if qps == nil {
+ return nil
+ }
+ parentPreemptableResource := qps.Parent.GetPreemptableResource()
+ used := qps.AllocatedResource.Clone()
+
+ // No usage, so nothing to preempt
+ if used.IsEmpty() {
+ return nil
+ }
+ used.SubOnlyExisting(qps.PreemptingResource)
+
+ // Calculate preemptable resource. +ve means Over utilized, -ve means
Under utilized, 0 means correct utilization
+ guaranteed := qps.GuaranteedResource.Clone()
+ actualPreemptableResource := used
Review Comment:
not needed, can be used directly
maybe rename `used` to `actual` and drop `actualPreemptableResource`
##########
pkg/scheduler/objects/preemption.go:
##########
@@ -749,6 +749,64 @@ func (qps *QueuePreemptionSnapshot)
GetRemainingGuaranteed() *resources.Resource
return resources.ComponentWiseMin(remaining, parentResult)
}
+func (qps *QueuePreemptionSnapshot) GetPreemptableResource()
*resources.Resource {
+ if qps == nil {
+ return nil
+ }
+ parentPreemptableResource := qps.Parent.GetPreemptableResource()
+ used := qps.AllocatedResource.Clone()
+
+ // No usage, so nothing to preempt
+ if used.IsEmpty() {
+ return nil
+ }
+ used.SubOnlyExisting(qps.PreemptingResource)
+
+ // Calculate preemptable resource. +ve means Over utilized, -ve means
Under utilized, 0 means correct utilization
+ guaranteed := qps.GuaranteedResource.Clone()
Review Comment:
don't need this clone use `qps.GetGuaranteedResource()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
