craigcondit commented on code in PR #810:
URL: https://github.com/apache/yunikorn-k8shim/pull/810#discussion_r1548194386
##########
pkg/cache/external/scheduler_cache.go:
##########
@@ -450,7 +450,7 @@ func (cache *SchedulerCache) StartPodAllocation(podKey
string, nodeID string) bo
}
// return if pod is assumed in cache, avoid nil
-func (cache *SchedulerCache) isAssumedPod(podKey string) bool {
Review Comment:
If we're making this public, we should keep the existing function name, and
wrap with an IsAssumedPod() which takes a lock. Otherwise, we risk external
callers not locking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
