pbacsko commented on PR #810: URL: https://github.com/apache/yunikorn-k8shim/pull/810#issuecomment-2032724355
> Instead of pushing the `allocationID` into `AssumePod` and fail the task from there we can fail the task in `UpdateAllocation` when the error is returned from `AssumePod`. Adding a second return value if we need more detail is a simpler change. Means no changes in the `task.go` needed. Removes the need for a locked and unlocked `getTask` etc I made the changes to simplify the PR. I also realized that there's no unit test code for `scheduler_callback.go` (`AsyncRMCallback`) which bothers me a bit. It's tested indirectly but we don't see if we miss anything. I suggest creating tests for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
