chenyulin0719 commented on code in PR #840:
URL: https://github.com/apache/yunikorn-core/pull/840#discussion_r1561258388
##########
pkg/scheduler/partition.go:
##########
@@ -616,8 +613,6 @@ func (pc *PartitionContext) addNodeToList(node
*objects.Node) error {
// removeNodeFromList removes the node from the list of partition nodes.
// This locks the partition.
func (pc *PartitionContext) removeNodeFromList(nodeID string) *objects.Node {
Review Comment:
The comment "**// This locks the partition.**" should be updated. The lock
responsibility has been moved down to pc.nodes. No partition lock here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]