chenyulin0719 commented on code in PR #840:
URL: https://github.com/apache/yunikorn-core/pull/840#discussion_r1561302325
##########
pkg/scheduler/partition.go:
##########
@@ -159,17 +159,19 @@ func (pc *PartitionContext) updatePreemption(conf
configs.PartitionConfig) {
}
func (pc *PartitionContext) updatePartitionDetails(conf
configs.PartitionConfig) error {
- pc.Lock()
- defer pc.Unlock()
+ // this must be performed without locking to avoid lock order
differences between PartitionContext and AppPlacementManager
Review Comment:
"this must be performed without lock" is not 100% sematically correct. We
"**postpone**" the partition locks to avoid lock order differences between
PartitionContext and AppPlacementManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
