wilfred-s commented on code in PR #838:
URL: https://github.com/apache/yunikorn-core/pull/838#discussion_r1565510897
##########
pkg/scheduler/objects/application.go:
##########
@@ -75,10 +76,12 @@ type StateLogEntry struct {
}
type Application struct {
- ApplicationID string // application ID
- Partition string // partition Name
- SubmissionTime time.Time // time application was submitted
- tags map[string]string // application tags used in scheduling
+ ApplicationID string // application ID
+ Partition string // partition Name
+ SubmissionTime time.Time // time application was submitted
+ tags map[string]string // application tags used in
scheduling
+ maxResource *resources.Resource // max resource setting from
namespace based on tags
+ guaranteed *resources.Resource // guaranteed resource setting from
namespace based on tags
Review Comment:
We do not need to store these as they are transient for the app. Read them
and return them from a function. `(*Application) GetResourcesFromTags()
(*Resource, *Resource)`
No need to lock the application as this should be called before the app is
added to the queue which means nothing can access it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
