pbacsko commented on code in PR #838:
URL: https://github.com/apache/yunikorn-core/pull/838#discussion_r1566561838
##########
pkg/scheduler/objects/queue.go:
##########
@@ -1281,6 +1238,37 @@ func (sq *Queue) internalGetMax(parentLimit
*resources.Resource) *resources.Reso
return resources.ComponentWiseMin(parentLimit, sq.maxResource)
}
+// GetProposedMaxQueueResource calculates the maximum resource for the queue
based on a proposed new value.
+// This is similar to GetMaxQueueSet but uses a value that has not been
applied as a maxResource for the queue.
+func (sq *Queue) GetProposedMaxQueueResource(maxRes *resources.Resource)
*resources.Resource {
+ // get the limit for the parent first and check against the queue's own
+ var limit *resources.Resource
+ if sq.parent == nil {
+ return nil
+ }
+ limit = sq.parent.GetMaxQueueSet()
+ return sq.internalGetProposedMax(limit, maxRes)
+}
+
+// internalGetProposedMax does the real max calculation.
+func (sq *Queue) internalGetProposedMax(parentLimit, maxRes
*resources.Resource) *resources.Resource {
+ sq.RLock()
Review Comment:
These new methods will be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
