chenyulin0719 commented on code in PR #844:
URL: https://github.com/apache/yunikorn-core/pull/844#discussion_r1568307812
##########
pkg/events/event_store.go:
##########
@@ -43,8 +43,9 @@ type EventStore struct {
func newEventStore(size uint64) *EventStore {
return &EventStore{
- events: make([]*si.EventRecord, size),
- size: size,
+ events: make([]*si.EventRecord, size),
+ size: size,
+ lastSize: size,
Review Comment:
Set initial value for lastSize to prevent uncessarily resize in
https://github.com/apache/yunikorn-core/blob/634380f109a0ad724cabcbdb5e2e7d78ec2debd5/pkg/events/event_store.go#L70-L73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
