chenyulin0719 commented on code in PR #844:
URL: https://github.com/apache/yunikorn-core/pull/844#discussion_r1568385907
##########
pkg/events/event_store_test.go:
##########
@@ -55,6 +56,16 @@ func TestStoreAndRetrieve(t *testing.T) {
assert.DeepEqual(t, records[0], event1,
cmpopts.IgnoreUnexported(si.EventRecord{}))
assert.DeepEqual(t, records[1], event2,
cmpopts.IgnoreUnexported(si.EventRecord{}))
+ // ensure that the underlying array of the return slice of
CollectEvents() isn't the same as the one in EventStore.events
Review Comment:
Change to another version, I think we can directly access the internal event
in the test.
`internalEvents := store.events[:2]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
