pbacsko commented on code in PR #855:
URL: https://github.com/apache/yunikorn-core/pull/855#discussion_r1577822246
##########
pkg/scheduler/objects/node.go:
##########
@@ -412,7 +417,7 @@ func (sn *Node) preConditions(ask *AllocationAsk, allocate
bool) bool {
func (sn *Node) preAllocateCheck(res *resources.Resource, resKey string) bool {
// cannot allocate zero or negative resource
if !resources.StrictlyGreaterThanZero(res) {
- log.Log(log.SchedNode).Debug("pre alloc check: requested
resource is zero",
+ getRateLimitedNodeLog().Debug("pre alloc check: requested
resource is zero",
Review Comment:
Note: it's not in the PR (yet), but we might do something with L#425-430:
```
if sn.IsReserved() {
if !sn.isReservedForApp(resKey) {
log.Log(log.SchedNode).Debug("pre alloc check: node
reserved for different app or ask",
zap.String("nodeID", sn.NodeID),
zap.String("resKey", resKey))
return false
}
}
```
Not sure how much output this generates. We can just log the successful
reservation (which we DON'T do right now, see `Node.Reserve()`) and ignore this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
