craigcondit commented on PR #855: URL: https://github.com/apache/yunikorn-core/pull/855#issuecomment-2074896804
I'm really not a fan of this. DEBUG is not used by default so there is no log spew in the normal case. However, when debugging we want all this detail. RateLimitedLogger doesn't take into account the parameters to the logger so it hides messages which are not duplicates of each other. This makes actual debugging much more difficult. Most loggers that do rate limiting only collapse completely duplicated messages, and only for a short time, so you'd see something like "last message repeated 28 times", etc. Our rate-limited logger doesn't do this. I don't think it's appropriate to rate-limit DEBUG messages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
