wilfred-s commented on code in PR #844:
URL: https://github.com/apache/yunikorn-k8shim/pull/844#discussion_r1607656208
##########
pkg/client/clients.go:
##########
@@ -67,38 +68,38 @@ func (c *Clients) GetConf() *conf.SchedulerConf {
return c.conf
}
+func (c *Clients) getInformers() []cache.SharedIndexInformer {
+ return []cache.SharedIndexInformer{
Review Comment:
This list should be in sync with the `informerTypes` or the other way
around. That was the issue that triggered YUNIKORN-2621
Not sure how we do that without manual work. The informers side is simple,
the listers are different for every type which makes it tricky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
