arhtur007 commented on code in PR #844:
URL: https://github.com/apache/yunikorn-k8shim/pull/844#discussion_r1608432164
##########
pkg/client/clients.go:
##########
@@ -67,38 +68,38 @@ func (c *Clients) GetConf() *conf.SchedulerConf {
return c.conf
}
+func (c *Clients) getInformers() []cache.SharedIndexInformer {
+ return []cache.SharedIndexInformer{
Review Comment:
Manually initializing each informer is more intuitive. However, in order to
ensure the list is synchronized, @chia7712 method is better.
Another nit suggestion is that we should move all informer-related code to
clients.go since all the informers are under the Client struct. Additionally,
interfaces.go should be combined with kubeclient.go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
