SophieTech88 commented on code in PR #850:
URL: https://github.com/apache/yunikorn-k8shim/pull/850#discussion_r1623136668
##########
pkg/client/apifactory.go:
##########
@@ -53,7 +54,7 @@ func (t Type) String() string {
type APIProvider interface {
GetAPIs() *Clients
- AddEventHandler(handlers *ResourceEventHandlers)
+ AddEventHandler(handlers *ResourceEventHandlers) error
Review Comment:
Yeah. When we change the `AddEventHandler` to return error, it affects the
`APIProvider interface`, too. If there is any suggestion for this part, please
let me know. Many thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
