SophieTech88 commented on code in PR #850:
URL: https://github.com/apache/yunikorn-k8shim/pull/850#discussion_r1623134755
##########
pkg/admission/namespace_cache.go:
##########
@@ -58,7 +59,10 @@ func NewNamespaceCache(namespaces
informersv1.NamespaceInformer) *NamespaceCache
nameSpaces: make(map[string]nsFlags),
}
if namespaces != nil {
-
namespaces.Informer().AddEventHandler(&namespaceUpdateHandler{cache: nsc})
+ _, err :=
namespaces.Informer().AddEventHandler(&namespaceUpdateHandler{cache: nsc})
Review Comment:
Yeah. Good insight. Updated in the new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
