chia7712 commented on code in PR #875:
URL: https://github.com/apache/yunikorn-core/pull/875#discussion_r1626498041
##########
pkg/common/utils.go:
##########
@@ -223,15 +209,15 @@ func ZeroTimeInUnixNano(t time.Time) *int64 {
return &tInt
}
-func WaitForCondition(eval func() bool, interval time.Duration, timeout
time.Duration) error {
+func WaitForCondition(interval time.Duration, timeout time.Duration, eval
func() bool) error {
Review Comment:
Just curious, why we change the argument order? I assume we can do similar
cleanup for k8hime module. And this changes of order will make difference
between core and k8shim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
