mean-world commented on code in PR #875:
URL: https://github.com/apache/yunikorn-core/pull/875#discussion_r1627601176
##########
pkg/common/utils.go:
##########
@@ -223,15 +209,15 @@ func ZeroTimeInUnixNano(t time.Time) *int64 {
return &tInt
}
-func WaitForCondition(eval func() bool, interval time.Duration, timeout
time.Duration) error {
+func WaitForCondition(interval time.Duration, timeout time.Duration, eval
func() bool) error {
Review Comment:
Since the argument order of the WaitFor function is different from that of
the WaitForCondition function, I need to replace the WaitFor function with the
WaitForCondition function. However, since the WaitFor function is more
frequently used in the project than the WaitForCondition function, I have
decided to change the argument order of the WaitForCondition function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
