chenyulin0719 commented on PR #859: URL: https://github.com/apache/yunikorn-k8shim/pull/859#issuecomment-2186439821
Based on my understanding. After this PR. One of the results is that the informer event handlers are no longer grab context lock when updating nodes or updating Pods. (NodeInformer/PodInformer go routine) I'm wondering if there have any racing when informer events(Pods/Nodes) comes during below go routine running: 1. (main goroutine) InitializeState() -> I'm not quite confident. 2. (shim scheduler goroutine) schedule() -> Should be safe. 3. (dispatcher goroutine) -> Should be safe. For the InitializeState(), I'm not quite confident for answering below question? Q: What will happen if NodeInformer update NodeA when InitializeState() is registring NodeA? Q: What will happen if PodInformer update PodA when InitializeState() is registring PodA? Is it still be safe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
