wilfred-s commented on code in PR #859:
URL: https://github.com/apache/yunikorn-k8shim/pull/859#discussion_r1675511183
##########
pkg/cache/context.go:
##########
@@ -1053,25 +1014,28 @@ func (ctx *Context) getApplication(appID string)
*Application {
func (ctx *Context) RemoveApplication(appID string) error {
Review Comment:
It needs a cleanup, might be better to do that via a seperate jira. That
makes it clear we're cleaning up dead code. We should keep the
RemoveApplication name and remove the RemoveApplicationInternal name. It is not
really internal as it gets called from outside the context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
