pbacsko commented on code in PR #896:
URL: https://github.com/apache/yunikorn-core/pull/896#discussion_r1651083027
##########
pkg/scheduler/ugm/manager.go:
##########
@@ -107,9 +107,6 @@ func (m *Manager) IncreaseTrackedResource(queuePath,
applicationID string, usage
zap.Stringer("resource", usage))
groupTracker := m.GetGroupTracker(appGroup)
if groupTracker == nil {
- log.Log(log.SchedUGM).Error("group tracker should be available
in groupTrackers map",
Review Comment:
It doesn't have to be there. Before the refactor, we did not have this check
because you can call `IncreaseTrackedResource()` on a `nil` group tracker.
However I don't like that approach, just want to return on `nil`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
