chia7712 commented on code in PR #896:
URL: https://github.com/apache/yunikorn-core/pull/896#discussion_r1651122623
##########
pkg/scheduler/ugm/manager.go:
##########
@@ -107,9 +107,6 @@ func (m *Manager) IncreaseTrackedResource(queuePath,
applicationID string, usage
zap.Stringer("resource", usage))
groupTracker := m.GetGroupTracker(appGroup)
if groupTracker == nil {
- log.Log(log.SchedUGM).Error("group tracker should be available
in groupTrackers map",
Review Comment:
Sorry for one more question:
> In that case we're guarded by:
why we not adding similar code to `IncreaseTrackedResource` for consistency?
It means that is fine to return directly if `appGroup` is empty. Also, we add
error log if `appGroup` is NOT empty and `ensureGroupTrackerForApp` is called?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
