chia7712 commented on code in PR #879:
URL: https://github.com/apache/yunikorn-k8shim/pull/879#discussion_r1682674604
##########
pkg/common/utils/utils.go:
##########
@@ -44,6 +45,10 @@ const userInfoKey = siCommon.DomainYuniKorn + "user.info"
const uniqueAutogenSuffix = "-uniqueautogen"
var pluginMode bool
+var (
+ // ErrorTimeout returned if waiting for a condition times out
+ ErrorTimeout = errors.New("timeout waiting for condition")
Review Comment:
this can't be constant, so maybe we can focus on "error message" instead of
`Error`. For example:
```go
const timeoutErrorMessage="timeout waiting for condition"
```
and then in testing we can check the error message instead of "error"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
