SP12893678 commented on code in PR #879:
URL: https://github.com/apache/yunikorn-k8shim/pull/879#discussion_r1682849499
##########
pkg/common/utils/utils.go:
##########
@@ -44,6 +45,10 @@ const userInfoKey = siCommon.DomainYuniKorn + "user.info"
const uniqueAutogenSuffix = "-uniqueautogen"
var pluginMode bool
+var (
+ // ErrorTimeout returned if waiting for a condition times out
+ ErrorTimeout = errors.New("timeout waiting for condition")
Review Comment:
OK. I will use `ErrorContains `to check it.
In core repo, `WaitForCondition `unit test have implemented with the same
usage.
I will create a issue to improve it.
##########
pkg/common/utils/utils.go:
##########
@@ -44,6 +45,10 @@ const userInfoKey = siCommon.DomainYuniKorn + "user.info"
const uniqueAutogenSuffix = "-uniqueautogen"
var pluginMode bool
+var (
+ // ErrorTimeout returned if waiting for a condition times out
+ ErrorTimeout = errors.New("timeout waiting for condition")
Review Comment:
OK. I will use `ErrorContains` to check it.
In core repo, `WaitForCondition` unit test have implemented with the same
usage.
I will create a issue to improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
