chenyulin0719 commented on code in PR #871:
URL: https://github.com/apache/yunikorn-k8shim/pull/871#discussion_r1698729618
##########
pkg/cache/task.go:
##########
@@ -543,7 +565,62 @@ func (task *Task) releaseAllocation() {
// some sanity checks before sending task for scheduling,
// this reduces the scheduling overhead by blocking such
// request away from the core scheduler.
-func (task *Task) sanityCheckBeforeScheduling() error {
+func (task *Task) sanityCheckBeforeScheduling() (error, bool) {
+ rejectTask := false
Review Comment:
Yes, rejectTask is always "false" for 1.6.0.
In 1.7.0, the rejectTask will be "true" if the sanity check fail due to
inconsistent matadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
