chenyulin0719 commented on code in PR #871:
URL: https://github.com/apache/yunikorn-k8shim/pull/871#discussion_r1698737199
##########
pkg/cache/task.go:
##########
@@ -543,7 +565,62 @@ func (task *Task) releaseAllocation() {
// some sanity checks before sending task for scheduling,
// this reduces the scheduling overhead by blocking such
// request away from the core scheduler.
-func (task *Task) sanityCheckBeforeScheduling() error {
+func (task *Task) sanityCheckBeforeScheduling() (error, bool) {
+ rejectTask := false
Review Comment:
Sorry for the unclear comment, I just added the hardcode part in the latest
commit.
If the sanity check failed due to inconsistent metadata, the sanity check
should return err and set the `rejectTask` to true. (Only happen after in 1.7.0)
https://github.com/chenyulin0719/yunikorn-k8shim/blob/7f8b8652953cda033a51da17fa1b0a222f24eb8c/pkg/cache/task.go#L587-L589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
