ryankert01 opened a new pull request, #889: URL: https://github.com/apache/yunikorn-k8shim/pull/889
### What is this PR for? source: https://github.com/apache/yunikorn-web/pull/174#issuecomment-1959233281 OCI annotations: https://github.com/opencontainers/image-spec/blob/main/annotations.md I believe most Yunikorn users are using the docker images into which we push, and so we should consider following a public protocol to set attributions for our public images. ``` org.opencontainers.image.title="yunikorn-scheduler-k8s" org.opencontainers.image.description="Apache Yunikorn" org.opencontainers.image.created="${build_date}" org.opencontainers.image.source="https://github.com/apache/yunikorn-k8shim"; org.opencontainers.image.url="https://hub.docker.com/r/apache/yunikorn"; org.opencontainers.image.revision="${build_revision}" org.opencontainers.image.license="Apache-2.0" org.opencontainers.image.documentation="https://yunikorn.apache.org"; ``` ### What type of PR is it? * [ ] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] - Documentation * [ ] - Hot Fix * [ ] - Refactoring ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/YUNIKORN-2446 ### How should this be tested? #### Make all 3 images ``` make image ``` #### Inspect if oci annotations is added into `config.labels` ``` docker image inspect --format='{{json .Config.Labels}}' apache/yunikorn:scheduler-amd64-latest | jq ``` ``` docker image inspect --format='{{json .Config.Labels}}' apache/yunikorn:scheduler-plugin-amd64-latest | jq ``` ``` docker image inspect --format='{{json .Config.Labels}}' apache/yunikorn:admission-amd64-latest | jq ``` ### Screenshots (if appropriate)  ### Questions: * [ ] - The licenses files need update. * [ ] - There is breaking changes for older versions. * [ ] - It needs documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
