craigcondit commented on code in PR #889:
URL: https://github.com/apache/yunikorn-k8shim/pull/889#discussion_r1714321670
##########
Makefile:
##########
@@ -522,6 +530,14 @@ plugin_image: $(OUTPUT)/third-party-licenses.md plugin
docker/plugin conf/schedu
--label "yunikorn-k8shim-revision=${SHIM_SHA}" \
--label "BuildTimeStamp=${DATE}" \
--label "Version=${VERSION}" \
+ --label org.opencontainers.image.title="yunikorn-scheduler-plugin-k8s" \
+ --label org.opencontainers.image.description="Apache Yunikorn Plugin" \
Review Comment:
Apache Yunikorn Plugin -> Apache YuniKorn Scheduler (Plugin) --
(capitalization / wording)
##########
Makefile:
##########
@@ -501,6 +501,14 @@ sched_image: $(OUTPUT)/third-party-licenses.md scheduler
docker/scheduler
--label "yunikorn-k8shim-revision=${SHIM_SHA}" \
--label "BuildTimeStamp=${DATE}" \
--label "Version=${VERSION}" \
+ --label org.opencontainers.image.title="yunikorn-scheduler-k8s" \
+ --label org.opencontainers.image.description="Apache Yunikorn
Scheduler" \
Review Comment:
Apache Yunikorn Scheduler -> Apache YuniKorn Scheduler (capitalization)
##########
Makefile:
##########
@@ -570,6 +586,14 @@ adm_image: $(OUTPUT)/third-party-licenses.md admission
docker/admission
--label "yunikorn-k8shim-revision=${SHIM_SHA}" \
--label "BuildTimeStamp=${DATE}" \
--label "Version=${VERSION}" \
+ --label
org.opencontainers.image.title="yunikorn-admission-controller-k8s" \
+ --label org.opencontainers.image.description="Apache Yunikorn Admission
Controller" \
Review Comment:
Apache Yunikorn Admission Controller -> Apache YuniKorn Admission Controller
(capitalization)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
