chenyulin0719 commented on code in PR #949:
URL: https://github.com/apache/yunikorn-core/pull/949#discussion_r1721400434
##########
pkg/common/resources/resources.go:
##########
@@ -363,18 +363,20 @@ func Sub(left, right *Resource) *Resource {
return out
}
-// SubOnlyExisting subtract delta from defined resource.
-// Ignore any type not defined in the base resource (ie receiver).
-// Used as part of the headroom updates as undefined resources are unlimited
-func (r *Resource) SubOnlyExisting(delta *Resource) {
+// SubOnlyExisting subtracts delta from base resource.
+// Ignores any type not defined in the base resource (ie receiver).
+// Used as part of the headroom updates as undefined resources are unlimited.
Review Comment:
No 'receiver', no 'the headroom updates' here anymore, we could align the
description with AddOnlyExisting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
