chenyulin0719 commented on code in PR #949:
URL: https://github.com/apache/yunikorn-core/pull/949#discussion_r1721425661
##########
pkg/common/resources/resources_test.go:
##########
@@ -1066,9 +1066,9 @@ func TestSubOnlyExistingNil(t *testing.T) {
}
}()
var r *Resource
- r.SubOnlyExisting(nil)
- if r != nil {
- t.Errorf("sub nil resources did not return nil resource: %v", r)
+ result := SubOnlyExisting(r, nil)
+ if result != nil {
+ t.Errorf("SubOnlyExisting with nil resources did not return nil
resource: %v", result)
Review Comment:
I think TestSubOnlyExistingNil() has been included in TestSubOnlyExisting(),
could we remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
