wilfred-s commented on code in PR #951:
URL: https://github.com/apache/yunikorn-core/pull/951#discussion_r1724534428
##########
pkg/metrics/scheduler.go:
##########
@@ -84,8 +84,8 @@ func InitSchedulerMetrics() *SchedulerMetrics {
Help: "Total number of attempts to allocate
containers. State of the attempt includes `allocated`, `rejected`, `error`,
`released`",
}, []string{"state"})
- s.applicationSubmission = prometheus.NewCounterVec(
- prometheus.CounterOpts{
+ s.applicationSubmission = prometheus.NewGaugeVec(
Review Comment:
A submission can not be changed. When an application is submitted it will
always be submitted. It should be a counter that keeps increasing. It is not a
state that we track it is a pure counter from start to shutdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
