zhuqi-lucas commented on code in PR #951:
URL: https://github.com/apache/yunikorn-core/pull/951#discussion_r1724565197
##########
pkg/metrics/queue.go:
##########
@@ -177,6 +203,10 @@ func (m *QueueMetrics) IncQueueApplicationsRejected() {
m.incQueueApplications(AppRejected)
}
+func (m *QueueMetrics) DecQueueApplicationsRejected() {
+ m.decQueueApplications(AppRejected)
+}
Review Comment:
@chenyulin0719 @wilfred-s
If i make sense right, we don't need to add decrease for following state?
Because they are final state besides the expired:
1. Rejected
2. Failed
3. Completed
And for expired, i don't think we need to tracking it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
