chenyulin0719 commented on code in PR #951:
URL: https://github.com/apache/yunikorn-core/pull/951#discussion_r1724753735
##########
pkg/metrics/queue.go:
##########
@@ -177,6 +203,10 @@ func (m *QueueMetrics) IncQueueApplicationsRejected() {
m.incQueueApplications(AppRejected)
}
+func (m *QueueMetrics) DecQueueApplicationsRejected() {
+ m.decQueueApplications(AppRejected)
+}
Review Comment:
@wilfred-s Understood, thanks for the explanation.
@zhuqi-lucas Not tracking expired metrics make sense to me.
To avoid any confusion, I think we should remove all the decrement function
for Rejected/Failed/Completed. WDYT?
##########
pkg/metrics/queue.go:
##########
@@ -177,6 +203,10 @@ func (m *QueueMetrics) IncQueueApplicationsRejected() {
m.incQueueApplications(AppRejected)
}
+func (m *QueueMetrics) DecQueueApplicationsRejected() {
+ m.decQueueApplications(AppRejected)
+}
Review Comment:
@wilfred-s Understood, thanks for the explanation.
@zhuqi-lucas Not tracking expired metrics make sense to me.
To avoid any confusion, I think we should remove all the decrement function
for Rejected/Failed/Completed. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
