zhuqi-lucas commented on code in PR #960:
URL: https://github.com/apache/yunikorn-core/pull/960#discussion_r1754181036
##########
pkg/metrics/queue.go:
##########
@@ -301,12 +301,46 @@ func (m *QueueMetrics) AddReleasedContainers(value int) {
m.containerMetrics.WithLabelValues(ContainerReleased).Add(float64(value))
}
-func (m *QueueMetrics) SetQueueGuaranteedResourceMetrics(resourceName string,
value float64) {
- m.setQueueResource(QueueGuaranteed, resourceName, value)
+func (m *QueueMetrics) SetQueueResourceMetrics(state string, resourceName
string, value float64) {
+ m.setQueueResource(state, resourceName, value)
}
-func (m *QueueMetrics) SetQueueMaxResourceMetrics(resourceName string, value
float64) {
- m.setQueueResource(QueueMax, resourceName, value)
+func (m *QueueMetrics) SetQueueNilResourceMetrics(state string) {
+ currResource, err := m.GetAllQueueStateMetrics(state)
+ if err != nil {
+ log.Log(log.Metrics).Warn("failed to get current guaranteed
resource metrics",
+ zap.Error(err))
+ return
+ }
+ for k := range currResource {
+ m.SetQueueResourceMetrics(state, k, float64(0))
+ }
+}
+
+func (m *QueueMetrics) GetAllQueueStateMetrics(state string)
(map[string]float64, error) {
+ metrics := make(map[string]float64)
+ metricFamilies, err := prometheus.DefaultGatherer.Gather()
+ if err != nil {
+ return nil, err
+ }
+
+ for _, metricFamily := range metricFamilies {
Review Comment:
It seems we have a lock for metric level, but not queue level:
```
func init() {
once.Do(func() {
m = &Metrics{
scheduler: InitSchedulerMetrics(),
queues: make(map[string]*QueueMetrics),
event: initEventMetrics(),
lock: locking.RWMutex{},
runtime: initRuntimeMetrics(),
}
})
}
```
Do we need to create a queue level lock to lock the knownResourceType?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
