craigcondit commented on code in PR #960:
URL: https://github.com/apache/yunikorn-core/pull/960#discussion_r1761684750
##########
pkg/metrics/queue.go:
##########
@@ -58,8 +59,9 @@ type QueueMetrics struct {
resourceMetricsLabel *prometheus.GaugeVec
// Deprecated - To be removed in 1.7.0. Replaced with queue label
Metrics
resourceMetricsSubsystem *prometheus.GaugeVec
- // Track known resource types.
+ // Track known resource types
knownResourceTypes map[string]struct{}
+ lock locking.RWMutex
Review Comment:
This doesn't need to be an RWMutex as we never lock for reads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
