blueBlue0102 commented on code in PR #1009:
URL: https://github.com/apache/yunikorn-core/pull/1009#discussion_r1899072074
##########
pkg/scheduler/objects/queue.go:
##########
@@ -113,9 +113,29 @@ func newBlankQueue() *Queue {
}
}
-// NewConfiguredQueue creates a new queue from scratch based on the
configuration
+// NewConfiguredQueue creates a new queue from scratch based on the
configuration and logs at info level
// lock free as it cannot be referenced yet
func NewConfiguredQueue(conf configs.QueueConfig, parent *Queue) (*Queue,
error) {
+ queue, err := newConfiguredQueueInternal(conf, parent)
+ if queue != nil {
+ log.Log(log.SchedQueue).Info("configured queue added to
scheduler",
+ zap.String("queueName", queue.QueuePath))
+ }
+ return queue, err
+}
+
+// NewConfiguredShadowQueue creates a new queue from scratch based on the
configuration and logs at debug level
Review Comment:
Hi @kousei47747, thank you for your contribution!
Could you provide more details about the differences between
`NewConfiguredQueue` and `NewConfiguredShadowQueue`?
Currently, it appears the only difference is the log level, which may be
confusing for those unfamiliar with shadow queues.
It would be helpful to explain when developers should use
`NewConfiguredQueue` versus `NewConfiguredShadowQueue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
