blueBlue0102 commented on PR #1009:
URL: https://github.com/apache/yunikorn-core/pull/1009#issuecomment-2646346368
If we need to silence all logs when creating shadow queues, it seems that
some places were missed.
For example:
- **`ACL.setUsers()`**:
- Related code:
[acl.go#L54](https://github.com/kousei47747/yunikorn-core/blob/36bb742f7e703efad7a0de19d066addd65fbc606/pkg/common/security/acl.go#L54)
- Call stack:
```plaintext
NewConfiguredQueue
└── sq.applyConf(conf)
└── security.NewACL()
└── acl.setUsers()
```
It seems that either adding an additional parameter or creating new
functions adds quite a lot of complexity to the codebase, but I don't have a
good idea for a third approach at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
