wilfred-s commented on PR #1002:
URL: https://github.com/apache/yunikorn-core/pull/1002#issuecomment-2566114947
> I have made the suggested modifications, and now the rejected information
in the pod event information is not very clear. Should we display more
rejection information?
I think that is a problem on the shim side. When I look at the processing of
the rejection there it does this:
```
func (app *Application) handleRejectApplicationEvent(reason string) {
log.Log(log.ShimCacheApplication).Info("app is rejected by scheduler",
zap.String("appID", app.applicationID))
// for rejected apps, we directly move them to failed state
dispatcher.Dispatch(NewFailApplicationEvent(app.applicationID,
fmt.Sprintf("%s: %s", constants.ApplicationRejectedFailure,
reason)))
}
```
It skips the rejected state and goes to failed. That is something we can
follow up separately. I think the code change beside the two nits on the core
side is looking good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
