rhh777 commented on code in PR #1002:
URL: https://github.com/apache/yunikorn-core/pull/1002#discussion_r1899998702


##########
pkg/scheduler/placement/placement_test.go:
##########
@@ -323,6 +323,15 @@ partitions:
        if err == nil || queueName != "" {
                t.Errorf("parent queue: app should not have been placed, queue: 
'%s', error: %v", queueName, err)
        }
+
+       // provided rule (2nd): submit to draining queue
+       app = newApplication("app1", "default", "root.testparent.testchild", 
user, nil, nil, "")
+       man.queueFn("root.testparent.testchild").MarkQueueForRemoval()
+       err = man.PlaceApplication(app)
+       queueName = app.GetQueuePath()
+       if err == nil || queueName != "" {
+               t.Errorf("Cannot Placing application in draining queue: '%s', 
error: %v", queueName, err)

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to