yangwwei commented on code in PR #186: URL: https://github.com/apache/yunikorn-release/pull/186#discussion_r1945960124
########## soak/framework/config.go: ########## @@ -0,0 +1,104 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +package framework + +import ( + "fmt" + "gopkg.in/yaml.v3" + "os" +) + +type Template struct { + Kubeconfig []TemplateFields `yaml:"kubeconfig"` + Node []TemplateFields `yaml:"node"` + Job []TemplateFields `yaml:"job"` + Scheduler []TemplateFields `yaml:"scheduler"` +} + +type TemplateFields struct { + Path *string `yaml:"path"` + MaxCount *string `yaml:"maxCount"` + DesiredCount *string `yaml:"desiredCount"` + PodCount *string `yaml:"podCount"` + Mode *string `yaml:"mode"` + Value *string `yaml:"value"` + VcoreRequests *string `yaml:"vcoreRequests"` + VcoreLimits *string `yaml:"vcoreLimits"` + MemoryRequests *string `yaml:"memoryRequests"` + MemoryLimits *string `yaml:"memoryLimits"` +} + +type TestCaseParams struct { + NodeMaxCount *int `yaml:"nodeMaxCount"` Review Comment: No need to use pointer ########## soak/framework/config.go: ########## @@ -0,0 +1,104 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +package framework + +import ( + "fmt" + "gopkg.in/yaml.v3" + "os" +) + +type Template struct { + Kubeconfig []TemplateFields `yaml:"kubeconfig"` + Node []TemplateFields `yaml:"node"` + Job []TemplateFields `yaml:"job"` + Scheduler []TemplateFields `yaml:"scheduler"` +} + +type TemplateFields struct { + Path *string `yaml:"path"` Review Comment: Should these be simple strings? why we need a pointer here? And add `omitempty` if empty is allowed in the field tag ########## soak/framework/config.go: ########## @@ -0,0 +1,104 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +package framework + +import ( + "fmt" + "gopkg.in/yaml.v3" + "os" +) + +type Template struct { + Kubeconfig []TemplateFields `yaml:"kubeconfig"` + Node []TemplateFields `yaml:"node"` + Job []TemplateFields `yaml:"job"` + Scheduler []TemplateFields `yaml:"scheduler"` +} + +type TemplateFields struct { + Path *string `yaml:"path"` + MaxCount *string `yaml:"maxCount"` + DesiredCount *string `yaml:"desiredCount"` + PodCount *string `yaml:"podCount"` + Mode *string `yaml:"mode"` + Value *string `yaml:"value"` + VcoreRequests *string `yaml:"vcoreRequests"` + VcoreLimits *string `yaml:"vcoreLimits"` + MemoryRequests *string `yaml:"memoryRequests"` + MemoryLimits *string `yaml:"memoryLimits"` +} + +type TestCaseParams struct { + NodeMaxCount *int `yaml:"nodeMaxCount"` + NodesDesiredCount *int `yaml:"nodesDesiredCount"` + NumPods *int `yaml:"numPods"` + NumJobs *int `yaml:"numJobs"` +} + +type Prom struct { + Query *string `yaml:"query"` Review Comment: Same, no need to use pointer ########## soak/framework/config.go: ########## @@ -0,0 +1,104 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +package framework + +import ( + "fmt" + "gopkg.in/yaml.v3" + "os" +) + +type Template struct { + Kubeconfig []TemplateFields `yaml:"kubeconfig"` + Node []TemplateFields `yaml:"node"` + Job []TemplateFields `yaml:"job"` + Scheduler []TemplateFields `yaml:"scheduler"` Review Comment: I got quite confused about this. Why we use `TemplateFileds` for all these options? Whats the benifit? If we go with ``` template: kubeconfig: - desiredCount: 3 ``` that will be really weird right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
