shravan-achar commented on code in PR #186: URL: https://github.com/apache/yunikorn-release/pull/186#discussion_r1947286102
########## soak/framework/config.go: ########## @@ -0,0 +1,104 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +package framework + +import ( + "fmt" + "gopkg.in/yaml.v3" + "os" +) + +type Template struct { + Kubeconfig []TemplateFields `yaml:"kubeconfig"` + Node []TemplateFields `yaml:"node"` + Job []TemplateFields `yaml:"job"` + Scheduler []TemplateFields `yaml:"scheduler"` +} + +type TemplateFields struct { + Path *string `yaml:"path"` + MaxCount *string `yaml:"maxCount"` Review Comment: I took another look. The templateFields (now split into Node/Job/Chaos Fields) need to have string for counts. As these take in value of TestCaseParams, a string substitution needs to happen first. For example, NodeFields.MaxCount: $MaxCount. Here, $MaxCount should be a string type whereas MaxCount refers to TestCaseParams.NodeMaxCount which is an int. ########## soak/framework/config.go: ########## @@ -0,0 +1,104 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +package framework + +import ( + "fmt" + "gopkg.in/yaml.v3" + "os" +) + +type Template struct { + Kubeconfig []TemplateFields `yaml:"kubeconfig"` + Node []TemplateFields `yaml:"node"` + Job []TemplateFields `yaml:"job"` + Scheduler []TemplateFields `yaml:"scheduler"` +} + +type TemplateFields struct { + Path *string `yaml:"path"` Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
