chenyulin0719 commented on code in PR #964:
URL: https://github.com/apache/yunikorn-k8shim/pull/964#discussion_r2030221797


##########
pkg/cache/application.go:
##########
@@ -392,6 +392,9 @@ func (app *Application) scheduleTasks(taskScheduleCondition 
func(t *Task) bool)
                if taskScheduleCondition(task) {
                        // for each new task, we do a sanity check before 
moving the state to Pending_Schedule
                        if err := task.sanityCheckBeforeScheduling(); err == 
nil {
+                               // check inconsistent pod metadata before 
submitting the task
+                               task.checkPodMetadataBeforeScheduling()
+

Review Comment:
   This is the start point of reviewing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to