chenyulin0719 commented on code in PR #964:
URL: https://github.com/apache/yunikorn-k8shim/pull/964#discussion_r2030221199
##########
pkg/cache/task.go:
##########
@@ -533,28 +534,38 @@ func (task *Task) releaseAllocation() {
// this reduces the scheduling overhead by blocking such
// request away from the core scheduler.
func (task *Task) sanityCheckBeforeScheduling() error {
- // After version 1.7.0, we should reject the task whose pod is unbound
and has conflicting metadata.
- if !utils.PodAlreadyBound(task.pod) {
- if err := utils.CheckAppIdInPod(task.pod); err != nil {
- log.Log(log.ShimCacheTask).Warn("Pod has inconsistent
application metadata and may be rejected in a future YuniKorn release",
- zap.String("appID", task.applicationID),
- zap.String("podName", task.pod.Name),
- zap.String("error", err.Error()))
Review Comment:
Since we're not going to reject pod if pod has inconsistent metadata, I
remove the metadata check from the sanity check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
