wilfred-s commented on PR #966: URL: https://github.com/apache/yunikorn-k8shim/pull/966#issuecomment-2807983540
We should only ever override the `default-scheduler` not any custom scheduler that has been set on a pod by default. If we have a custom scheduler we should let the pod pass and not make any changes. That check should be made *before* we do anything else. We can then add an override of custom scheduler option. We can use that if we want to force everything in the cluster to be scheduled by YuniKorn based on namespaces etc. Adding the option to override some but not all of the schedulers passed in, is I think not going to give the correct user experience. So in processPod before checking user info: * check the schedulername is not `default-scheduler` or `yunikorn` * check if custom scheduler override is set to `false`: return admission response to allow the pod without any changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
