kaichiachen commented on code in PR #966:
URL: https://github.com/apache/yunikorn-k8shim/pull/966#discussion_r2055418413
##########
pkg/admission/admission_controller.go:
##########
@@ -194,7 +194,16 @@ func (c *AdmissionController) processPod(req
*admissionv1.AdmissionRequest, name
log.Log(log.Admission).Info("bypassing namespace",
zap.String("namespace", namespace))
return admissionResponseBuilder(uid, true, "", nil)
}
- patch = updateSchedulerName(patch)
+
+ // Only override default-scheduler unless override is enabled
+ if pod.Spec.SchedulerName == "default-scheduler" ||
+ (c.conf.GetOverrideCustomSchedulers() && pod.Spec.SchedulerName
!= constants.SchedulerName) {
+ patch = updateSchedulerName(patch)
+ } else {
+ log.Log(log.Admission).Info("bypassing scheduler name update",
+ zap.String("schedulerName", pod.Spec.SchedulerName),
+ zap.Bool("overrideCustomSchedulers",
c.conf.GetOverrideCustomSchedulers()))
+ }
Review Comment:
Fair enough. Only logs when updating scheduler name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
