ayubpathan commented on PR #1086: URL: https://github.com/apache/yunikorn-core/pull/1086#issuecomment-4829335080
Addressed the review comments: * Moved queue property defaults into resetProperties(). * Simplified quota preemption handling so UpdateQueueProperties() always calls setPreemptionTime() and the zero-delay cleanup is handled inside that method. * Added coverage that removing quota.preemption.delay clears the queued preemption start time. * Rebased on current master, which includes #1088 and #1091. Validation: * go test ./pkg/scheduler/objects -run TestUpdateQueuePropertiesReset|TestQuotaPreemptionSettings|TestQueue_setPreemptionTime|TestQueueBackoffProperties * make lint * make test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
