PoiBlackTea commented on PR #1108: URL: https://github.com/apache/yunikorn-core/pull/1108#issuecomment-5106296385
> @PoiBlackTea > > As a human :), I am happy that AI pointed out in place edits of the variables etc could be the possible reason of this flakiness. Of course, Our brain too guessed the same and also "possible" causes and reasons around the same lines of "Could be because of variables not being reset? or Could be because same input has been passed to different tests" or something like that. Thanks for the feedback! I've updated the PR to remove the factory method. We now clone the victim allocations inside t.Run() to keep the test clean and declarative without extra abstractions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
